Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate MaxInstance fix #399

Merged
merged 2 commits into from
Sep 23, 2023
Merged

Calculate MaxInstance fix #399

merged 2 commits into from
Sep 23, 2023

Conversation

coenm
Copy link
Contributor

@coenm coenm commented Sep 21, 2023

Implements #398

@coenm
Copy link
Contributor Author

coenm commented Sep 21, 2023 •
edited
Loading

Looking at https://ci.appveyor.com/project/SimonCropp/diffengine/builds/48091678 is seems that only the MacOS run failed but the Visual studio 2022 run also failed.

My best guess is that the test fail as multiple test write to the same environment variable. I have removed the unittest.

@SimonCropp
Copy link
Member

thanks. very nicely done. i will merge and deploy this in a few hours. i will also bump the reference in Verify so u dont need to explicitly ref diffengine

@SimonCropp SimonCropp added this to the 12.3.0 milestone Sep 23, 2023
@SimonCropp SimonCropp merged commit fc489ef into VerifyTests:main Sep 23, 2023
2 checks passed
@coenm coenm deleted the MaxInstancesFix branch September 23, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature
Milestone
12.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@coenm @SimonCropp