Skip to content

LLZK backend for Halo2 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 34 commits into
base: main
Choose a base branch
from
Open

LLZK backend for Halo2 #15

wants to merge 34 commits into from

Conversation

0xddom
Copy link
Collaborator

@0xddom 0xddom commented Oct 3, 2025 •
edited
Loading

Adds missing pieces of the LLZK backend and makes changes on the llzk crate fixing bugs and adding features the backend turned out needing.

It's still missing a few pieces so it's not complete yet:

  • Locate and fix the memory bug that pops up seemingly at random
  • Leaks (that don't trigger on MacOS and I only noticed because of CI)

@0xddom 0xddom requested a review from a team October 3, 2025 14:38
shankarapailoor
shankarapailoor reviewed Oct 3, 2025
View reviewed changes
shankarapailoor
shankarapailoor requested changes Oct 3, 2025
View reviewed changes
Copy link
Contributor

@shankarapailoor shankarapailoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of this looks good but I had a few questions and I think we need to make sure comments are on all the public functions/structs in modules.

llzk-macro/src/pass.rs

const CREATE_FUNCTION_PREFIX: &str = "mlirCreate";

pub fn generate(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a comment here?

@tim-hoffman tim-hoffman mentioned this pull request Oct 6, 2025
Merged
@0xddom 0xddom mentioned this pull request Oct 7, 2025
Merged
@0xddom
Copy link
Collaborator Author

0xddom commented Oct 17, 2025

This should be ready for final review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shankarapailoor shankarapailoor shankarapailoor requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0xddom @shankarapailoor