Refactor: Convert TaskManagerActor to class and simplify SwiftUI integration #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… files - Extract TaskNode class from TaskQueueActor.swift to TaskNode.swift - Extract AutoReleaseContinuationBox class from TaskQueueActor.swift to AutoReleaseContinuationBox.swift - Improve code organization and maintainability 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Major architectural improvements: - Convert TaskManagerActor from actor to class with manual synchronization using OSAllocatedUnfairLock - Convert TaskNode from class to struct with internal state management - Remove batch methods from TaskManagerActor (no longer needed) - Remove async from cancel methods (not needed with class-based implementation) - Remove TaskQueueActor and TaskStackActor (consolidated into TaskManagerActor) Key changes: - TaskNode is now a value type (struct) with internal State managed by OSAllocatedUnfairLock - TaskManagerActor uses OSAllocatedUnfairLock for thread-safe state management - All tests updated to work with the new implementation - Added Swift Testing framework tests alongside XCTest Benefits: - Reduced actor overhead for better performance - More granular control over synchronization - Simplified API with batch methods removed - Maintains thread safety with manual locking All tests passing ✅ 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Renamed TaskManagerActor class to TaskManager for simplicity - Renamed TaskManagerActor.swift file to TaskManager.swift - Renamed SwiftUI property wrapper from TaskManager to LocalTask to avoid naming conflicts - Updated all test files to use new class name - Updated README documentation with new naming conventions - Removed references to batch operations which were already removed - Updated all code examples to show synchronous API usage
- Remove LocalTaskWrapper and expose TaskManager directly from LocalTask property wrapper - Add taskWithBinding extension method to TaskManager for SwiftUI binding support - Update README documentation and examples - Simplify the overall API surface
- TaskManager now conforms to Sendable directly without @unchecked - Remove taskWithBinding extension that was causing issues - Simplified SwiftUI integration
- Test queued task execution order with waitInCurrent mode - Test task cancellation with dropCurrent mode - Test concurrent execution with different keys - Test cancellation propagation across queued tasks - Test completion order guarantees with wait mode These tests verify the internal TaskNode wait functionality through the public TaskManager API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Core Refactoring
File Organization
TaskNode.swift)AutoReleaseContinuationBox.swift)SwiftUI Integration
Test Results
All tests passing ✅
Breaking Changes
TaskManagerActorrenamed toTaskManager@TaskManagerto@LocalTask🤖 Generated with Claude Code