Skip to content

Add key-based task cancellation support #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 14, 2025
Merged

Add key-based task cancellation support #11

merged 1 commit into from
Jun 14, 2025

Conversation

@muukii
Copy link
Contributor

@muukii muukii commented Jun 14, 2025 •
edited
Loading

Summary

  • Add ability to cancel tasks by specific key in TaskManager
  • Add corresponding method to SwiftUI's TaskManagerActorWrapper
  • Add tests to verify the new functionality

Changes

  • Added cancel(key:) method to TaskManagerActor
  • Added cancelTask(key:) method to TaskManagerActorWrapper
  • Added 3 test cases:
    • Verify that only tasks with the specified key are cancelled
    • Verify behavior when multiple tasks are queued with the same key
    • Verify that cancelling a non-existent key doesn't crash

Test plan

  • Verified all tests pass with swift test
  • Confirmed new test cases work as expected

🤖 Generated with Claude Code

@muukii @claude
Add key-based task cancellation support
622d7ab 
- Add cancel(key:) method to TaskManagerActor for cancelling tasks with specific keys
- Add cancelTask(key:) method to TaskManagerActorWrapper for SwiftUI integration
- Add comprehensive tests for key-based cancellation functionality

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@muukii muukii merged commit bb1a916 into main Jun 14, 2025
2 checks passed
@muukii muukii deleted the feature/add-key-based-cancellation branch June 14, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@muukii