Skip to content

Pre-render index page #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

SignpostMarv
Copy link
Contributor

Improves further upon #2, possibly maxing out the page speed score & negating a rare bug that would occur due to the GitHub API rate limiting rules.

  • moved the prettyDate() output from the header widget to the repo widgets to normalise heights of all widgets
  • don't run prettyDate() on pre-render pass, increased margin to eliminate vertical repositioning of text
  • pre-render with phantomjs via grunt-html-snapshot, using grunt-contrib-rename to overwrite index.html with pre-rendered content.
  • run prettyDate() in output, displaying recent update info for all repos.
  • remaining page speed improvements at time of writing relate to third-party APIs (i.e. speed score is not likely to improve any further)
  • eliminates the rare scenario where no repos are listed due to rate-limiting on the GitHub API.

Comparisons:

  • before - mobile speed score 89, desktop 95
  • after - mobile speed score 96, dekstop 97

…ed score from 89 to 96, desktop speed score from 96 to 97; remaining speed score issues at time of writing are due to GitHub & Twitter APIs)
@@ -137,17 +136,6 @@
repo.hotness += weightForWatchers * repo.watchers / createdDelta;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the hotness is not used anymore we should remove it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed it and related variables.

@SignpostMarv
Copy link
Contributor Author

Updated as requested, no score changes

mihai-vlc added a commit that referenced this pull request Feb 6, 2016
@mihai-vlc mihai-vlc merged commit ce15cae into VerbalExpressions:master Feb 6, 2016
@mihai-vlc
Copy link
Contributor

Looks nice, thank you !

@SignpostMarv SignpostMarv deleted the recent-update-display-all branch February 6, 2016 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants