Allow a custom config class to be used via class_alias #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duellsy
added a commit
that referenced
this pull request
Nov 7, 2014
Allow a custom config class to be used via class_alias
|
This is a bad practice, and should not be done. The best thing to do here would be to resolve the config repository out of the ioc. |
|
I can't see this causing any issues however if you'd like to submit an alternative PR I'd be open to it |
|
It would 100% cause issues for people who have deleted all the facades aliases. |
|
Granted |
|
I'll send a pull... |
|
Cheers |
|
Actually, when are you doing a laravel 5 only version, because it would make a load of sense to use the config repository contract? |
|
#113 Should work on laravel 4 and laravel 5. |
duellsy
pushed a commit
that referenced
this pull request
Mar 3, 2021
vblais-activix
pushed a commit
to activix/revisionable
that referenced
this pull request
Jun 19, 2023
* Revert VentureCraft#112 and follow VentureCraft#113 * Update RevisionableTrait.php * support Laravel 9 * Update readme.md remove misleading space (not being trimmed in model) * Bump dependencies for Laravel 10 * Update readme.md doc: userResponsible returns false and not null. --------- Co-authored-by: Lance Pioch <lancepioch@gmail.com> Co-authored-by: Reinier <reiniergombert@hotmail.com> Co-authored-by: Cristian Tabacitu <cristian.tabacitu@digitallyhappy.com> Co-authored-by: AHMAD BWIDANI <ahmad2135@gmail.com> Co-authored-by: Shift <shift@laravelshift.com> Co-authored-by: CedricFrossard <113982099+CedricFrossard@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From develop this time.