feat: make footer global across authenticated pages#79
Conversation
|
@dnyaneshwari44 is attempting to deploy a commit to the venkat-kolasani's projects Team on Vercel. A member of the Team first needs to authorize it. |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesGlobal footer and hash navigation
Estimated review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/App.js`:
- Line 156: The global Footer rendered from App.js is using fragment-only links
that break on authenticated routes because they stay on the current page. Update
src/components/common/Footer.jsx so the navigation items that currently point to
`#features` and `#faq` use landing-page-safe destinations instead, and make sure the
Footer component still works correctly when rendered from routes like /dashboard
and /calendar.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/Home.jsx`:
- Around line 22-24: The hash-link scrolling in Home.jsx currently uses
scrollIntoView with start alignment, which leaves targets hidden behind the
fixed navbar. Update the hash navigation logic in the Home component to account
for the header offset, either by adjusting the scroll position in the existing
scrollIntoView flow or by adding scroll-margin-top to the target sections like
`#features` and `#faq` so their headings remain visible after navigation.
- Around line 21-26: The delayed scroll in Home.jsx can still run after unmount
or a route change. Update the effect that contains the scroll logic to store the
timer id from setTimeout and return a cleanup function that clears it, using the
existing Home component/effect and the scrollIntoView callback as the reference
points.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 10953cfc-fd6d-4304-98be-07fa1829b611
📒 Files selected for processing (2)
src/components/common/Footer.jsxsrc/pages/Home.jsx
✅ Files skipped from review due to trivial changes (1)
- src/components/common/Footer.jsx
Summary
Adds the existing
Footercomponent to the shared application layout so it is displayed consistently across all authenticated pages while preserving the existing footer on the landing page. The layout was also updated to keep the footer positioned correctly on pages with varying content heights.Fixes #68
Type of change
Changes made
Footercomponent into the shared application layout (src/App.js).flex-1to the main content container to ensure proper page layout with both short and long content.Test plan
npm run test:cipasses (frontend)cd backend && npm testpasses (if API/backend changed)npm run check:architecturepasses locallycd backend && npm run dev).envfiles committedScreenshots / recording
Before
After
Checklist
docs/if schema changed (Not applicable)console.logdebug noise left behinddocs/TESTING.mdif unsure what CI expectsSummary by CodeRabbit