BetterSettings: Fix Missing Icons#4236
Open
thororen1234 wants to merge 6 commits into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces several new SVG icons and integrates them into the betterSettings plugin to provide visual indicators for different settings sections. The review feedback points out that the Menu.MenuItem component should use the icon prop instead of iconLeft to ensure icons are rendered correctly. Furthermore, it is recommended to use a group element with the evenodd fill rule in the VencordIcon component to correct rendering artifacts and simplify the code.
Contributor
|
You could take the favicon from vencord.dev https://github.com/Vencord/vencord.dev/blob/main/public%2Ffavicon.svg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
please someone have a better svg for the vencord icon 😭