feat(types): Type a bunch of stores #3861
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add store types
thororen1234
changed the title
Owner
|
epic lint fail |
Owner
|
you typed so many stores wtf 😭 how long did you spend on this are they all correct though or did you somehow autogenerate these and there may be some flaws? |
Contributor
Author
|
I added a bunch of the stores I already typed awhile ago but a bunch of the other stores were typed by @imjustprism to my knowledge all of them were manually typed |
Contributor
Author
|
I spent like 4-5 hours on the types I did prism spent way too long 😭 |
|
Hey, I already typed RelationshipStore here #3856 Hoping my PRs will get reviewed soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types for MediaEngineStore, OverridePremiumTypeStore, SpellCheckStore, UploadAttachmentStore
Updates types for GuildRoleStore, RelationshipStore, StickersStore
Moves PetPet and PreviewMessage to the
webpack/commonimport ofUploadAttachmentStoreinstead ofUploadStorefindMoved VoiceMessages to the
@webpack/commonimport ofMediaEngineStoreinstead of the find