-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New dev tools #2791
base: dev
Are you sure you want to change the base?
New dev tools #2791
Conversation
If someone could review this when they have a chance that would be nice |
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
@CodiumAI-Agent /describe |
TitleNew dev tools User descriptionNeeds to be merged with this pr not editing the description of two prs at once, see the other one for details PR TypeEnhancement, Tests, Documentation Description
Changes walkthrough 📝
|
export function initWs(isManual = false) { | ||
let wasConnected = isManual; | ||
let hasErrored = false; | ||
const ws = socket = new WebSocket(`ws://localhost:${PORT}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason to use both ws
and socket
instead of just using either?
const newSource = src.replace(matcher, replacement as string); | ||
|
||
if (src === newSource) throw "Had no effect"; | ||
Function(newSource); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this do anything?
const AllModulesNoti = ErrorBoundary.wrap(function ({ done, close }: AllModulesNotiProps) { | ||
const [state, setState] = useState<0 | 1 | -1>(0); | ||
done.then(setState.bind(null, 1)).catch(setState.bind(null, -1)); | ||
console.log("test"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to be removed
Needs to be merged with this pr
not editing the description of two prs at once, see the other one for details