feat(plugin): PasswordProtect #2637
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Use case? |
Vendicated
reviewed
Jun 30, 2024
Comment on lines
+13
to
+21
| await openModalLazy(async () => { | ||
| return modalProps => <PasswordModal modalProps={modalProps} channelId={channelId} type={ModalType.Access} callback={async password => { | ||
| if (password) { | ||
| cb(await checkPassword(password, channelId)); | ||
| } else { | ||
| cb(false); | ||
| } | ||
| }} />; | ||
| }); |
There was a problem hiding this comment.
Suggested change
| await openModalLazy(async () => { | |
| return modalProps => <PasswordModal modalProps={modalProps} channelId={channelId} type={ModalType.Access} callback={async password => { | |
| if (password) { | |
| cb(await checkPassword(password, channelId)); | |
| } else { | |
| cb(false); | |
| } | |
| }} />; | |
| }); | |
| openModal(modalProps => ( | |
| <PasswordModal | |
| modalProps={modalProps} | |
| channelId={channelId} | |
| type={ModalType.Access} | |
| callback={async password => { | |
| if (password) { | |
| cb(await checkPassword(password, channelId)); | |
| } else { | |
| cb(false); | |
| } | |
| }} | |
| />; | |
| )); |
Vendicated
reviewed
Jun 30, 2024
Comment on lines
+22
to
+42
| {!isProtected && ( | ||
| <> | ||
| <Menu.MenuItem | ||
| id="vc-password-protect-lock" | ||
| label="Lock" | ||
| color="brand" | ||
| action={() => openLockModal(channelId)} | ||
| /> | ||
| </> | ||
| )} | ||
|
|
||
| {isProtected && ( | ||
| <> | ||
| <Menu.MenuItem | ||
| id="vc-password-protect-unlock" | ||
| label="Unlock" | ||
| color="danger" | ||
| action={() => openUnlockModal(channelId)} | ||
| /> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Suggested change
| {!isProtected && ( | |
| <> | |
| <Menu.MenuItem | |
| id="vc-password-protect-lock" | |
| label="Lock" | |
| color="brand" | |
| action={() => openLockModal(channelId)} | |
| /> | |
| </> | |
| )} | |
| {isProtected && ( | |
| <> | |
| <Menu.MenuItem | |
| id="vc-password-protect-unlock" | |
| label="Unlock" | |
| color="danger" | |
| action={() => openUnlockModal(channelId)} | |
| /> | |
| </> | |
| )} | |
| {!isProtected | |
| ? <> | |
| <Menu.MenuItem | |
| id="vc-password-protect-lock" | |
| label="Lock" | |
| color="brand" | |
| action={() => openLockModal(channelId)} | |
| /> | |
| </> | |
| : <> | |
| <Menu.MenuItem | |
| id="vc-password-protect-unlock" | |
| label="Unlock" | |
| color="danger" | |
| action={() => openUnlockModal(channelId)} | |
| /> | |
| </> | |
| } |
Vendicated
reviewed
Jun 30, 2024
| { | ||
| find: ".gatedContent,", | ||
| replacement: { | ||
| match: /this.props/, |
| ], | ||
|
|
||
| patchProps(props: NSFWBlockProps) { | ||
| const channel = getCurrentChannel(); |
There was a problem hiding this comment.
Suggested change
| const channel = getCurrentChannel(); | |
| const channelId = SelectedChannelStore.getChannelId(); |
Comment on lines
+21
to
+26
| export async function reloadChannel() { | ||
| const channel = getCurrentChannel(); | ||
| NavigationRouter.transitionTo("/channels/@me"); | ||
| await new Promise(r => setTimeout(r, 0)); | ||
| NavigationRouter.transitionTo(`/channels/${channel.guild_id || "@me"}/${channel.id}`); | ||
| } |
Vendicated
force-pushed
the
dev
branch
3 times, most recently
from
bc67db1 to
b333deb
Compare
|
It'd be better if this plugin encrypted the messages you send and decrypts when a new message is loaded |
out of scope; have you tried using a messaging app designed for encryption? afaik this is designed mostly as a "don't accidentally open the wrong channel" plugin |
3 tasks
Nuckyz
force-pushed
the
dev
branch
9 times, most recently
from
fa092cf to
eb63a54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PasswordProtect
Allows you to password protect your dms and channels!