Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new plugin: NoMouseNavigation #2314

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Moondarker
Copy link

NoMouseNavigation allows users to disable the default handling of mouse side buttons (3 and 4).

Many people use side buttons for PTT. By default, Discord will handle those by navigating forward/backward through visited pages while the app is in focus, causing severe butthurt for PTT users. This plugin simply prevents the default behavior, PTT continues working normally.

P.S. I'm not sure if adding myself into the dev list in constants.ts is appropriate, but looking through other plugins, I couldn't find any files where authors are added in the way described by 2_PLUGINS.md, so I assumed this is the new undocumented standard? Anyways, I can always revert that, just lmk.

@Moondarker Moondarker force-pushed the no-mouse-sidebutton-nav branch from 92286cd to 04d0ffc Compare April 1, 2024 13:15
@Moondarker Moondarker requested a review from Vendicated April 2, 2024 10:33
@Moondarker Moondarker force-pushed the no-mouse-sidebutton-nav branch from 04d0ffc to 0d23296 Compare May 15, 2024 16:49
@Moondarker Moondarker requested a review from Vendicated May 15, 2024 16:52
Nuckyz
Nuckyz previously approved these changes May 17, 2024
@Nuckyz Nuckyz changed the base branch from main to dev May 17, 2024 06:32
@Nuckyz Nuckyz dismissed their stale review May 17, 2024 06:34

stale

@Nuckyz
Copy link
Collaborator

Nuckyz commented May 17, 2024

I tested and it seems like mouseup is not being fired for my side buttons, which makes the plugin not work

@Vendicated
Copy link
Owner

works for me. on linux, maybe this is platform dependant?

@Moondarker
Copy link
Author

I tested and it seems like mouseup is not being fired for my side buttons, which makes the plugin not work

Which OS are you on? If you're on Linux, which distro and are you on X11 or Wayland?

@Nuckyz
Copy link
Collaborator

Nuckyz commented May 17, 2024

I tested and it seems like mouseup is not being fired for my side buttons, which makes the plugin not work

Which OS are you on? If you're on Linux, which distro and are you on X11 or Wayland?

windows haha

@Moondarker
Copy link
Author

Moondarker commented May 25, 2024

I tested and it seems like mouseup is not being fired for my side buttons, which makes the plugin not work

Which OS are you on? If you're on Linux, which distro and are you on X11 or Wayland?

windows haha

Can't reproduce at all... But it should work the same way everywhere.

Do you want to say that it navigates on mousedown for you? What if you replace the handled event to mousedown?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants