-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSR param, get custom field attrib by name, readme updates #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdbarron
requested review from
astro2000j,
brantpeery,
danguite-ven,
denvenafi,
Pmaraveyias,
Saadi6 and
wilddev65
February 11, 2022 03:04
denvenafi
reviewed
Feb 11, 2022
wilddev65
reviewed
Feb 11, 2022
wilddev65
reviewed
Feb 11, 2022
wilddev65
requested changes
Feb 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would like the Device parameter in New-TppCertificate to be reworked
@wilddev65 this has been completed. can you have a look? |
denvenafi
approved these changes
Feb 14, 2022
denvenafi
approved these changes
Feb 14, 2022
wilddev65
approved these changes
Feb 14, 2022
@denvenafi @wilddev65 thanks for all the great feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Csr
parameter toNew-TppCertificate
andInvoke-TppCertificateRenewal
. Closes Add "CSR" parameter to New-TppCertificate & Invoke-TppCertificateRenewal #76Get-TppVersion
. Closes Get-TppVersion does not display revision number #80NoWorkToDo
parameter toNew-TppCertificate
to turn off processing for that updateDevice
parameter toNew-TppCertificate
to allow creation of devices and apps-IncludeAssociated
inGet-TppIdentity
. Closes Get-TPPIdentity -IncludeAssociated #82