Preconditions are now supported by clients. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously preconditions were implemented as VQL lazy queries. This works fine as long as there are no materialized queries in the artifact sources. If there are, the query will be materialized even if the precondition prevents it from running. This PR makes clients support precondition natively. The server will declare the precondition in the request and the client will not execute any of the VQL if the precondition fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously preconditions were implemented as VQL lazy queries. This
works fine as long as there are no materialized queries in the
artifact sources. If there are, the query will be materialized even if
the precondition prevents it from running.
This PR makes clients support precondition natively. The server will
declare the precondition in the request and the client will not
execute any of the VQL if the precondition fails.