Fix JSX leading space in translations #3195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scudette
pushed a commit
that referenced
this pull request
Feb 15, 2024
Fix JSX leading space for tags in translations. As an example, [malmoeb's post](https://infosec.exchange/@malmoeb/111675841615532732) displays the following capture where the link is not spaced from the text (`fromhttps://`). <img width="475" alt="cdbf6801ad02d31e" src="https://github.com/Velocidex/velociraptor/assets/46688461/cf8c387c-69d7-4c46-ab76-6534d8599cd2"> This commit ensures any tags within the JSX translations are prefixed with text to avoid accidental white space trimming. 
scudette
pushed a commit
that referenced
this pull request
Feb 15, 2024
Fix JSX leading space for tags in translations. As an example, [malmoeb's post](https://infosec.exchange/@malmoeb/111675841615532732) displays the following capture where the link is not spaced from the text (`fromhttps://`). <img width="475" alt="cdbf6801ad02d31e" src="https://github.com/Velocidex/velociraptor/assets/46688461/cf8c387c-69d7-4c46-ab76-6534d8599cd2"> This commit ensures any tags within the JSX translations are prefixed with text to avoid accidental white space trimming. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix JSX leading space for tags in translations. As an example, malmoeb's post displays the following capture where the link is not spaced from the text (
fromhttps://).This commit ensures any tags within the JSX translations are prefixed with text to avoid accidental white space trimming.