Fix dangling pointers around WinVerifyTrust #3176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
scudette
added a commit
that referenced
this pull request
Dec 26, 2023
This addresses the crash related to #2574. The underlying issue is the lack of references to go-managed objects due to unsafe unsafe.Pointer usage, allowing them to be garbage collected before use in `WinVerifyTrust`. Alternative approaches to this could be using an unmanaged buffer or `runtime.Pinner` (requires go 1.21). Garbage collection on necessary object example (ci, fi, filename, etc.) https://go.dev/play/p/pAOR_bE7wh9 --------- Co-authored-by: Mike Cohen <mike@velocidex.com>
scudette
added a commit
that referenced
this pull request
Dec 26, 2023
This addresses the crash related to #2574. The underlying issue is the lack of references to go-managed objects due to unsafe unsafe.Pointer usage, allowing them to be garbage collected before use in `WinVerifyTrust`. Alternative approaches to this could be using an unmanaged buffer or `runtime.Pinner` (requires go 1.21). Garbage collection on necessary object example (ci, fi, filename, etc.) https://go.dev/play/p/pAOR_bE7wh9 --------- Co-authored-by: Mike Cohen <mike@velocidex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the crash related to #2574. The underlying issue is the lack of references to go-managed objects due to unsafe unsafe.Pointer usage, allowing them to be garbage collected before use in
WinVerifyTrust.Alternative approaches to this could be using an unmanaged buffer or
runtime.Pinner(requires go 1.21).Garbage collection on necessary object example (ci, fi, filename, etc.)
https://go.dev/play/p/pAOR_bE7wh9