Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a standards-compliant HTTP User-Agent, including version number. #3065

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

hillu
Copy link
Contributor

@hillu hillu commented Oct 31, 2023

No description provided.

@scudette
Copy link
Contributor

Do you think leaking the version in the clear is a good move from an op-sec perspective?

@hillu
Copy link
Contributor Author

hillu commented Oct 31, 2023

Not sure if including the version number is that much worse than just telling whoever may be interested just the product name.

To be honest, I was mainly thinking about client/server communication.

For all other HTTP usage, we may as well not set a UA at all.

@hillu
Copy link
Contributor Author

hillu commented Nov 1, 2023

@scudette what do you think about leaving out the User-Agent altogether for "external" communication?

@scudette
Copy link
Contributor

scudette commented Nov 1, 2023

Happy to drop it completely and expose it though the http client plugin parameter

https://docs.velociraptor.app/vql_reference/plugin/http_client/

But probably if we dropped it now it would allow fingerprinting the version to identify newer clients?

Maybe we need to have it configurable?

@hillu hillu force-pushed the user-agent branch 2 times, most recently from e6bb903 to 4bada97 Compare November 2, 2023 15:36
- Add optional user_agent parameter for http_client and upload_webdav
- Don't set UA for other HTTP connections (DynDNS, inventory access, LogScale)

By default, Go's net/http would set its own user-agent string.
@hillu
Copy link
Contributor Author

hillu commented Nov 2, 2023

Happy to drop it completely and expose it though the http client plugin parameter

Done for http_client and upload_webdav

@scudette scudette merged commit 4c31254 into Velocidex:master Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants