Fix AptSources deb822 parsing bug and add deb822 test #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WHERE URIs was used to prevent parsing empty deb822 sections, however the condition was placed in the wrong query.
Move use of get() out of WHERE, since it does not work if the column is not present. Add a suggestion that removes the embedded GPG content.
Additionally, add another list file to verify option parsing.
scudette
pushed a commit
that referenced
this pull request
Sep 10, 2023
#2851 was merged a bit too early. My mistake, I should have marked it as a draft. A misplaced `WHERE URIs` prevented deb822 parsing to work altogether. This is now fixed, and I've included some sources files to the tests, along with another lists file that includes two common options. I've added these new files to the tests Sources and SourcesFlattened, but not SourcesCacheFiles. I've also fixed the VQL suggestions after realising that `get()` doesn't work in WHERE as I assumed it would (see discussion [here](https://discord.com/channels/624244632552734750/865024982399320114/1147470384359284746) with a detailed explanation from Mike).
scudette
pushed a commit
that referenced
this pull request
Sep 10, 2023
#2851 was merged a bit too early. My mistake, I should have marked it as a draft. A misplaced `WHERE URIs` prevented deb822 parsing to work altogether. This is now fixed, and I've included some sources files to the tests, along with another lists file that includes two common options. I've added these new files to the tests Sources and SourcesFlattened, but not SourcesCacheFiles. I've also fixed the VQL suggestions after realising that `get()` doesn't work in WHERE as I assumed it would (see discussion [here](https://discord.com/channels/624244632552734750/865024982399320114/1147470384359284746) with a detailed explanation from Mike).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2851 was merged a bit too early. My mistake, I should have marked it as a draft. A misplaced
WHERE URIsprevented deb822 parsing to work altogether. This is now fixed, and I've included some sources files to the tests, along with another lists file that includes two common options.I've added these new files to the tests Sources and SourcesFlattened, but not SourcesCacheFiles.
I've also fixed the VQL suggestions after realising that
get()doesn't work in WHERE as I assumed it would (see discussion here with a detailed explanation from Mike).