Uploads are now deduplicated on store_as_name. #2415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is often convenient in VQL to repeat the same finding from the same file on multiple rows. But previously each invocation of the upload() function would cause the file to be uploaded again Although it is possible to work around this using the cache() function it is more useful to only upload the same file once but provide a reference to the upload on each row. This PR deduplicates the uploads by store_as_name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often convenient in VQL to repeat the same finding from the same file on multiple rows. But previously each invocation of the upload() function would cause the file to be uploaded again
Although it is possible to work around this using the cache() function it is more useful to only upload the same file once but provide a reference to the upload on each row.
This PR deduplicates the uploads by store_as_name.