Bugfix: Store client specific dashboard in client space. #2255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old Reports are migrated to the notebook renderer which needs to write the result to the datastore. This requires choosing an appropriate location for the notebook on disk. Previously all notebooks were put in the global notebooks directory but some reports are specific for each client. This PR refactores the paths of where reports will be stored. Currently reports are used for: 1. Home screen (dashboard) (type: "SERVER_EVENT") 2. Client's VQL Drilldown screen (type: "CLIENT") 3. View Artifacts screen (type: "ARTIFACT_DESCRIPTION") 4. Client Monitoring report (to be deprecated - same as monitoring notebook).
scudette
added a commit
that referenced
this pull request
Nov 18, 2022
The old Reports are migrated to the notebook renderer which needs to write the result to the datastore. This requires choosing an appropriate location for the notebook on disk. Previously all notebooks were put in the global notebooks directory but some reports are specific for each client. This PR refactores the paths of where reports will be stored. Currently reports are used for: 1. Home screen (dashboard) (type: "SERVER_EVENT") 2. Client's VQL Drilldown screen (type: "CLIENT") 3. View Artifacts screen (type: "ARTIFACT_DESCRIPTION") 4. Client Monitoring report (to be deprecated - same as monitoring notebook).
scudette
added a commit
that referenced
this pull request
Nov 18, 2022
* Font adjustments in themes (#2242) * Font adjustments in themes * Specified font-weight per theme * Update colors in tree widget to match theme (#2243) * Update Server.Import.PreviousReleases (#2245) * Fixed bug in VQL Drilldown view (#2246) Also removed react warnings and fixed the checkbox styling in some themes. * Fixed bug in line splitting in execve() plugin (#2248) * Bump loader-utils from 1.4.1 to 1.4.2 in /gui/velociraptor (#2249) Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/webpack/loader-utils/releases) - [Changelog](https://github.com/webpack/loader-utils/blob/v1.4.2/CHANGELOG.md) - [Commits](webpack/loader-utils@v1.4.1...v1.4.2) --- updated-dependencies: - dependency-name: loader-utils dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Theme fixes (#2250) * Bugfix: Dashboard refresh button did not refresh it (#2251) * Fix context management in event table updates. (#2252) Fixes a deadlock with the pool client that restarts the event table lot. * Return EOF from timed result set when reading past the end (#2253) * Bugfix: Dashboard refresh button did not refresh it (#2254) * Bugfix: Store client specific dashboard in client space. (#2255) The old Reports are migrated to the notebook renderer which needs to write the result to the datastore. This requires choosing an appropriate location for the notebook on disk. Previously all notebooks were put in the global notebooks directory but some reports are specific for each client. This PR refactores the paths of where reports will be stored. Currently reports are used for: 1. Home screen (dashboard) (type: "SERVER_EVENT") 2. Client's VQL Drilldown screen (type: "CLIENT") 3. View Artifacts screen (type: "ARTIFACT_DESCRIPTION") 4. Client Monitoring report (to be deprecated - same as monitoring notebook). * Bugfix: Do not expand sparse files when importing (#2257) The offline collection zip may contain very sparse files (e.g. $J) so we do not want to automatically expand those files when importing as a collection. This PR introduces a new accessor "collector_sparse" which does not automatically expand sparse files, instead the importer copies the index file as it is. Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: predictiple <predictiple@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old Reports are migrated to the notebook renderer which needs to write the result to the datastore. This requires choosing an appropriate location for the notebook on disk. Previously all notebooks were put in the global notebooks directory but some reports are specific for each client.
This PR refactores the paths of where reports will be stored.
Currently reports are used for: