Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parse_yaml function #1050

Merged
merged 9 commits into from
May 5, 2021
Merged

Add parse_yaml function #1050

merged 9 commits into from
May 5, 2021

Conversation

clayscode
Copy link
Contributor

No description provided.

@clayscode clayscode changed the title This PR adds a parse_yaml function Add parse_yaml function May 3, 2021
@clayscode
Copy link
Contributor Author

Hmm, SELECT parse_yaml(...) FROM scope() seems to work correctly, but selecting subelements returns null for everything.

@clayscode
Copy link
Contributor Author

Alright, I believe I've fixed the issue. My PR, however, adds an additional dependency to https://github.com/kubernetes-sigs/yaml which is an MIT licensed repository with contributors.

scudette
scudette reviewed May 5, 2021
View reviewed changes
Copy link
Contributor

@scudette scudette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do need some tests here but I can add them later if you like.

go.mod Outdated
@@ -14,7 +14,7 @@ require (
github.com/Velocidex/go-elasticsearch/v7 v7.3.1-0.20191001125819-fee0ef9cac6b
github.com/Velocidex/go-yara v1.1.10-0.20210423154840-dace8239c158
github.com/Velocidex/json v0.0.0-20210402154432-68206e1293d0
github.com/Velocidex/ordereddict v0.0.0-20210502082334-cf5d9045c0d1
github.com/Velocidex/ordereddict v0.0.0-20200723153557-9460a6764ab8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is going backwards

go.sum Outdated
github.com/golang/protobuf v1.4.3/go.mod h1:oDoupMAO8OvCJWAcko0GGGIgR6R6ocIYbsSw735rRwI=
github.com/golang/protobuf v1.5.0 h1:LUVKkCeviFUMKqHa4tXIIij/lbhnMbP7Fn5wKdKkRh4=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe run go mod tidy

@scudette scudette merged commit 372797d into Velocidex:master May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scudette scudette scudette left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clayscode @scudette