HTTP recorder

[dmcrodrigues]

Vinyl should provide a mechanism to automatically record all http traffic (request+response) for posterior replay.

[RuiAAPeres]

The "automatically" is something that bothers me a bit, should we make this explicit? Should we simply record if there are no tracks?

[dmcrodrigues]

I think this should be configurable. I was thinking something like this:

Record modes

• None
• New tracks (track not available on vinyl)
• All

[RuiAAPeres]

I think they would sit well here then: TurntableConfiguration.

[dmcrodrigues]

Maybe instead of All we should have a Once mode to simply create a vinyl and then use it without any new recording, that way you can reason about the requests expected to be handled.

[dmcrodrigues]

I agree, TurntableConfiguration seems the right place to configure this.

[RuiAAPeres]

I didn't understand the reasoning behind the Once. So let's look at the cases:

enum RecordingMode {
case None
case NewTracks
case All/Once

• .None: If a track is not found, it will raise a fatalError (current behaviour)
• .NewTracks: For every track not found, a request will be made and stored
• .All/Once: For every track, a request will be made and stored

Is this what you have in mind?

[dmcrodrigues]

I don't know if we really need/want a .All.

• .Once: For every vinyl (file) not found, record and store every request performed to create that vinyl.

Makes any sense?

[RuiAAPeres]

Makes sense, I am just not sold with the naming. 😁

[hugocf]

Suggestion❓

enum RecordingMode {
case None
case NewTracks
case NewVinyl
}

And btw, looks like the plural of “vinyl” is “vinyl” 😄

[RuiAAPeres]

With your suggestion, you actually raised an interesting question which is: on a test with multiple requests, how should those requests be treated? As individual vinyl with a single track, or one vinyl with multiple tracks? I am 👍 for the later.