Skip to content

Add routine execution tools for GuideAgent #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rayruizhiliao merged 26 commits into from
Jan 29, 2026
Merged

Add routine execution tools for GuideAgent #112

rayruizhiliao merged 26 commits into from
Jan 29, 2026

Conversation

@rayruizhiliao
Copy link
Contributor

@rayruizhiliao rayruizhiliao commented Jan 28, 2026 •
edited
Loading

This PR

  • added an execute_routine() method to RoutineDiscoveryAgent
  • updated (refactored) the llm client for RoutineDiscoveryAgent

@rayruizhiliao rayruizhiliao changed the title feat: execute routine tool Add execute_routine tool Jan 28, 2026
@rayruizhiliao rayruizhiliao marked this pull request as draft January 28, 2026 19:24
@rayruizhiliao rayruizhiliao changed the title Add execute_routine tool Add routine execution tools for GuideAgent Jan 28, 2026
@rayruizhiliao rayruizhiliao marked this pull request as ready for review January 28, 2026 20:26
@dimavrem22
Copy link
Contributor

dimavrem22 commented Jan 28, 2026

close_tab_when_done should prob be always true. we dont want agent opening up and keeping a bunch of tabs

@rayruizhiliao
Copy link
Contributor Author

rayruizhiliao commented Jan 29, 2026 •
edited
Loading

close_tab_when_done should prob be always true. we dont want agent opening up and keeping a bunch of tabs

Set close_tab_when_done to True by default in commit ea7a310

@claude

This comment was marked as outdated.

Sign in to view
@claude
Copy link

claude bot commented Jan 29, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
dimavrem22
dimavrem22 reviewed Jan 29, 2026
View reviewed changes
@rayruizhiliao rayruizhiliao merged commit 7fe8635 into main Jan 29, 2026
11 checks passed
@alex-w-99 alex-w-99 deleted the add_tools branch February 8, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimavrem22 dimavrem22 dimavrem22 approved these changes

@alex-w-99 alex-w-99 Awaiting requested review from alex-w-99 alex-w-99 is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rayruizhiliao @dimavrem22