Skip to content

Migrate to uv, add lint fixes, improvements and some unit tests #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jan 30, 2025
Merged

Migrate to uv, add lint fixes, improvements and some unit tests #28

merged 8 commits into from
Jan 30, 2025

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Jan 29, 2025 •
edited
Loading

PR Type

Other

Short Description

  • Migrate to use uv for package management
  • Update lint settings to conform with aieng-template (coding style)
  • Perform lint based fixes including adding typing annotations, fixing ruff errors
  • Refactor the status cli command function to use smaller helper fns
  • Add unit test github action workflow

Tests Added

  • Unit tests added in tests/vec_inf/cli/test_utils.py

@amrit110 amrit110 self-assigned this Jan 29, 2025
@amrit110 amrit110 changed the title Migrate to uv lint fixes Migrate to uv, add lint fixes Jan 29, 2025
@amrit110 amrit110 changed the base branch from main to develop January 29, 2025 20:53
@amrit110 amrit110 mentioned this pull request Jan 29, 2025
Open
6 tasks
@amrit110 amrit110 requested a review from XkunW January 30, 2025 16:15
@amrit110 amrit110 changed the title Migrate to uv, add lint fixes Migrate to uv, add lint fixes, improvements and some unit tests Jan 30, 2025
@XkunW
Copy link
Contributor

XkunW commented Jan 30, 2025

LGTM!

@XkunW XkunW merged commit 9a5a175 into develop Jan 30, 2025
3 checks passed
@XkunW XkunW deleted the migrate_to_uv_lint_fixes branch January 30, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XkunW XkunW Awaiting requested review from XkunW

Assignees

@amrit110 amrit110

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amrit110 @XkunW