Skip to content

B/reg term bugfix #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

B/reg term bugfix #16

wants to merge 3 commits into from

Conversation

jwilles
Copy link
Collaborator

@jwilles jwilles commented May 26, 2025

This pull request includes a version bump for the vbll package and minor fixes to the loss function calculations in two files to ensure proper operator precedence. Below is a summary of the changes:

Version Update:

  • Updated the version of the vbll package from 0.4.8 to 0.4.9 in both pyproject.toml and setup.py. [1] [2]

Bug Fixes:

  • Corrected operator precedence in the loss_fn function in vbll/layers/classification.py by adding parentheses around (kl_term_ll + kl_term_noise) to ensure proper calculation of the regularization term.
  • Applied the same fix for operator precedence in the loss_fn function in vbll/layers/regression.py.

@jwilles jwilles requested a review from jharrison42 May 26, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant