Conversation
amrit110
left a comment
amrit110
left a comment
There was a problem hiding this comment.
Looks good overall, left a few comments to address. Great work.
There was a problem hiding this comment.
please update the name of the file to code-config-chart.tsx and update imports. We are using kebab-case for the module names.
There was a problem hiding this comment.
please update the name of the file to geographic-chart.tsx and update imports. We are using kebab-case for the module names.
There was a problem hiding this comment.
please update the name of the file to meaningfulness-chart.tsx and update imports. We are using kebab-case for the module names.
| </div> | ||
| <div className="text-xs text-gray-600 dark:text-gray-400 mt-1">Code Files</div> | ||
| <div className="text-xs text-gray-500 dark:text-gray-500"> | ||
| ({forkData ? ((forkData.summary.code_files / (forkData.summary.code_files + forkData.summary.config_files)) * 100).toFixed(1) : 72.2}%) |
There was a problem hiding this comment.
there is some bug here. Shows NaN% when i tried it on my end.
| import sys | ||
| from collections import Counter | ||
| from pathlib import Path | ||
| from typing import Any, Dict, List |
There was a problem hiding this comment.
Consider replacing Dict and List types with built-in types. Use of typing.Dict and typing.List is now deprecated since python 3.9. (https://stackoverflow.com/questions/37087457/difference-between-defining-typing-dict-and-dict)
2 participants
PR Type
[Feature]
Short Description
Adds a new row of data into the /analytics page, showing more detailed insights about usage of our github account.
Tests Added
None so far.