Merged
Conversation
lotif
requested changes
Feb 5, 2026
|
|
||
| def create_web_fetch_tool() -> FunctionTool: | ||
| """Create an ADK FunctionTool for fetching web content.""" | ||
| return FunctionTool(func=web_fetch) |
Collaborator
There was a problem hiding this comment.
Where do you use this function? I can only see it being used on a test.
Member
Author
There was a problem hiding this comment.
Yet to add my updated agent implementation that uses. Thought I'd keep my PRs small so they are easier to review.
Collaborator
There was a problem hiding this comment.
That being said, it looks a little overkill to have that single line in a function. I'd just do FunctionTool(func=web_fetch) on the callers instead.
Member
Author
There was a problem hiding this comment.
Yeah agree, but i thought its nice to have these explicit constructor methods, when i finally have this as a usable package.
lotif
approved these changes
Feb 5, 2026
Collaborator
lotif
left a comment
There was a problem hiding this comment.
Approved with one minor optional comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a new tool to the tools package. The tool is for fetching web content (HTML pages and PDFs given a URL)
Type of Change
Changes Made
Testing
uv run pytest tests/)uv run mypy <src_dir>)uv run ruff check src_dir/)Manual testing details:
Tested with Agent that can call this tool
Screenshots/Recordings
NA
Related Issues
NA
Deployment Notes
Checklist