Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor aggregator use fit, transform methods #526

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

amrit110
Copy link
Member

@amrit110 amrit110 commented Dec 8, 2023

PR Type ([Feature | Fix | Documentation | Test])

Refactor

Short Description

...

Tests Added

...

@amrit110 amrit110 self-assigned this Dec 8, 2023
@amrit110 amrit110 added the refactor Refactor existing code, with same or similar functionality label Dec 8, 2023
Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #526 (2a3775b) into main (4cd2eb2) will increase coverage by 0.06%.
The diff coverage is 78.26%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #526      +/-   ##
==========================================
+ Coverage   66.06%   66.13%   +0.06%     
==========================================
  Files         100      100              
  Lines        9743     9750       +7     
==========================================
+ Hits         6437     6448      +11     
+ Misses       3306     3302       -4     
Files Coverage Δ
cyclops/data/aggregate.py 77.87% <78.26%> (+2.53%) ⬆️

Impacted file tree graph

@amrit110 amrit110 marked this pull request as ready for review December 8, 2023 04:55
@amrit110 amrit110 merged commit 033de88 into main Dec 8, 2023
7 checks passed
@amrit110 amrit110 deleted the refactor_aggregator branch December 8, 2023 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Refactor existing code, with same or similar functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant