Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
==========================================
+ Coverage 89.87% 90.61% +0.74%
==========================================
Files 10 10
Lines 1442 1407 -35
==========================================
- Hits 1296 1275 -21
+ Misses 146 132 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to the onboarding CLI tool, focusing on making environment file generation and validation dynamic and template-driven. The changes ensure that the
.envfile is created and validated based on a provided.env.exampletemplate, improving flexibility and reducing hardcoded configuration. The CLI now requires the user to specify the.env.examplepath, and all relevant logic and tests have been updated accordingly.Key changes include:
Environment file generation and validation
.envfile is now generated by reading the provided.env.exampletemplate, preserving its order, comments, and structure, and filling in values from team and global configuration data. This replaces the previous hardcoded section-based approach. [1] [2].envfile is now performed against the keys defined in the.env.exampletemplate, instead of a hardcoded list, making the process adaptable to different bootcamps or configurations. [1] [2]CLI interface and argument handling
--env-exampleargument specifying the path to the.env.exampletemplate. Argument validation has been updated to enforce this requirement, and related logic ensures the template is used throughout onboarding. [1] [2] [3] [4] [5] [6] [7]Firestore/global configuration
bootcamp_name, allowing for bootcamp-specific global configuration documents rather than a single shared one. [1] [2] [3] [4]Testing updates
.env.examplefiles, and to pass the new--env-exampleargument, ensuring that test coverage matches the new dynamic environment file logic. [1] [2] [3] [4]Miscellaneous
0.5.4to0.6.0to reflect these breaking and feature changes.