Skip to content

Python: Replace NotImplemented with default values or errors #7978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Alkalem wants to merge 2 commits into
base: dev
Choose a base branch
from
+19 −19
Open

Python: Replace NotImplemented with default values or errors #7978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7c0662
Replace NotImplemented in Architecture patch methods with default val…
Alkalem Feb 21, 2026
a8f76b8
Replace NotImplemented with NotImplementedError in other API base cla…
Alkalem Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions python/architecture.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2400,7 +2400,7 @@ def assemble(self, code: str, addr: int = 0) -> bytes:
b'\\x0f\\x84\\x04\\x00\\x00\\x00'
>>>
"""
return NotImplemented
raise NotImplementedError

def is_never_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
"""
Expand All @@ -2420,7 +2420,7 @@ def is_never_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
False
>>>
"""
return NotImplemented
return False

def is_always_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
"""
Expand All @@ -2441,7 +2441,7 @@ def is_always_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
False
>>>
"""
return NotImplemented
return False

def is_invert_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
"""
Expand All @@ -2461,7 +2461,7 @@ def is_invert_branch_patch_available(self, data: bytes, addr: int = 0) -> bool:
False
>>>
"""
return NotImplemented
return False

def is_skip_and_return_zero_patch_available(self, data: bytes, addr: int = 0) -> bool:
"""
Expand All @@ -2484,7 +2484,7 @@ def is_skip_and_return_zero_patch_available(self, data: bytes, addr: int = 0) ->
False
>>>
"""
return NotImplemented
return False

def is_skip_and_return_value_patch_available(self, data: bytes, addr: int = 0) -> bool:
"""
Expand All @@ -2505,7 +2505,7 @@ def is_skip_and_return_value_patch_available(self, data: bytes, addr: int = 0) -
False
>>>
"""
return NotImplemented
return False

def convert_to_nop(self, data: bytes, addr: int = 0) -> Optional[bytes]:
"""
Expand All @@ -2524,7 +2524,7 @@ def convert_to_nop(self, data: bytes, addr: int = 0) -> Optional[bytes]:
b'\\x90\\x90'
>>>
"""
return NotImplemented
raise NotImplementedError

def always_branch(self, data: bytes, addr: int = 0) -> Optional[bytes]:
"""
Expand All @@ -2546,7 +2546,7 @@ def always_branch(self, data: bytes, addr: int = 0) -> Optional[bytes]:
(['jmp', ' ', '0x9'], 5)
>>>
"""
return NotImplemented
raise NotImplementedError

def invert_branch(self, data: bytes, addr: int = 0) -> Optional[bytes]:
"""
Expand All @@ -2569,7 +2569,7 @@ def invert_branch(self, data: bytes, addr: int = 0) -> Optional[bytes]:
(['jl', ' ', '0xa'], 6)
>>>
"""
return NotImplemented
raise NotImplementedError

def skip_and_return_value(self, data: bytes, addr: int, value: int) -> Optional[bytes]:
"""
Expand All @@ -2588,7 +2588,7 @@ def skip_and_return_value(self, data: bytes, addr: int, value: int) -> Optional[
(['mov', ' ', 'eax', ', ', '0x0'], 5)
>>>
"""
return NotImplemented
raise NotImplementedError

def register_calling_convention(self, cc: 'callingconvention.CallingConvention') -> None:
"""
Expand Down
6 changes: 3 additions & 3 deletions python/fileaccessor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ def __init__(self):
self._cb.write = self._cb.write.__class__(self._write)

def get_length(self):
return NotImplemented
raise NotImplementedError

def read(self, offset, length):
return NotImplemented
raise NotImplementedError

def write(self, offset: int, data: bytes):
return NotImplemented
raise NotImplementedError

def __len__(self):
return self.get_length()
Expand Down
6 changes: 3 additions & 3 deletions python/filemetadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@ def _navigate(self, ctxt: Any, view: ViewName, offset: int) -> bool:
return False

def get_current_view(self) -> str:
return NotImplemented
raise NotImplementedError

def get_current_offset(self) -> int:
return NotImplemented
raise NotImplementedError

def navigate(self, view: ViewName, offset: int) -> bool:
return NotImplemented
raise NotImplementedError


class SaveSettings:
Expand Down
6 changes: 3 additions & 3 deletions python/interaction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -833,7 +833,7 @@ def show_report_collection(self, title, reports):
pass

def get_text_line_input(self, prompt, title):
return NotImplemented
raise NotImplementedError

def get_int_input(self, prompt, title):
while True:
Expand All @@ -849,10 +849,10 @@ def get_address_input(self, prompt, title, view, current_address):
return get_int_input(prompt, title)

def get_choice_input(self, prompt, title, choices):
return NotImplemented
raise NotImplementedError

def get_large_choice_input(self, prompt, title, choices):
return NotImplemented
raise NotImplementedError

def get_open_filename_input(self, prompt, ext):
return get_text_line_input(prompt, "Open File")
Expand Down