Macho loader treating symbol bindings wrong

[mostobriv]

Version and Platform (required):

• Binary Ninja Version: 4.1.5218-dev Personal (423fe6c2)
• OS: MacOS

Bug Description:
I think there is some misconception of how the macho bindings works, as instead of putting the value that can be located by the external symbol to specified address, current BNs macho loader defining the symbol at address instead.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Open attached binary
2. Go to 0x100008310

Expected Behaviour:
As i've said in the description, there should be not defined symbol (void* SYMBOL = ...), but the external value should be stored at address (void* data_XXX = SYMBOL).

test_binary.zip

[bdash]

This is a result of logic within ParseChainedFixups that applies symbols when processing bind opcodes for imports:

binaryninja-api/view/macho/machoview.cpp

Lines 3376 to 3386 in 67ae186

	if (ordinal < importTable.size())
	{
	import_entry entry = importTable.at(ordinal);
	uint64_t targetAddress = GetStart() + (chainEntryAddress - m_universalImageOffset);
	if (!entry.name.empty())
	{
	reloc.address = targetAddress;
	DefineMachoSymbol(ImportAddressSymbol, entry.name,
	targetAddress,
	entry.weak ? WeakBinding : GlobalBinding, true);

I thought that perhaps it is trying to ensure that pointers within the __got / __nl_symbol_ptr sections have their names applied, but there's code within ParseSymbolTable that explicitly deals with applying names within those sections.

[0cyn]

Resolved in versions >= dev 5.1.7565 with #6839