Skip to content

"Import Header File" menu doesn't let you select multiple files #3893

@fuzyll

Description

@fuzyll

Version and Platform (required):

  • Binary Ninja Version: 3.3.4061-dev
  • OS: macOS
  • OS Version: 13.2
  • CPU Architecture ARM64

Bug Description:
The "Import Header File" menu has two unexpected behaviors:

  1. Despite the fact that it says "Header File(s)" above the first input box, you can't actually select multiple files with the file picker.
  2. The picker does filtering incorrectly and prevents you from navigating into folders unless you switch it to "All Files"

Steps To Reproduce:

  1. Open up the Import Header Files menu using either the command palette or Analysis -> Import Header File
  2. Click the Browse button in the top-right
  3. Observe that you are unable to select any sub-folder with the default filter (C/C++ Headers), which prevents you in many situations from being able to actually select the file you need
  4. Observe that this is no longer an issue if you select All Files
  5. Also observe how much faster the file picker works in All Files mode, which may be a related problem
  6. Observe that you also cannot select multiple files

Expected Behavior:
I expect to be able to select multiple files because it says "Header File(s)". I also don't expect to be prevented from selecting the files I need because the default filter, despite matching the file I want, does not let me navigate into the folder that has the file.

Metadata

Metadata

Assignees

Labels

Component: UIIssue needs changes to the user interfaceEffort: LowIssues require < 1 week of workImpact: LowIssue is a papercut or has a good, supported workaround

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions