UIContext::activeContext() becomes null after hitting command palette shortcut 3 times consecutively

[0cyn]

Version and Platform (required):

• Binary Ninja Version: 3.2
• OS: macOS x86_64

Bug Description:
UIContext::activeContext() becomes null after hitting command palette shortcut 3 times consecutively. This causes any items depending on it to disappear from the command palette. This can also be replicated by a UI plugin executing the action to open it 3 times.

Without access to the MainWindow class, the user will have to manually refocus on the application before any UI plugins can access it again.

Steps To Reproduce:

1. Open BinaryNinja
2. Press ⌘ + P 3 times, note missing items on 3rd time (1st is normal, 2nd time will close the palette)
3. Press ⌘ + P a 4th time and note all of the activeContext() dependent items suddenly return

This seems like unintended behavior, and could potentially cause a crash if any code assumes activeContext will not be null

[bpotchik]

There was a focus issue in the command palette causing some strange behavior. Also, opening a command palette while it's already open will use the globalActionContext, which appears to be by design.

Fixed in 5.1.7882-dev.