Stack view under load causes UI lockup

[yrp604]

Version and Platform (required):

• Binary Ninja Version: 2.4.3149-dev
• OS: Windows
• OS Version: 11

Bug Description:
When navigating around a binary while its still being analyzed, the UI will lockup and be completely unresponsive for 30+ seconds at a time.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Get a large binary, I'm using XNU from /System/Library/Kernels/kernel.release.t6000
2. Bring the stack view into focus
3. Before the binary has finished analyzing, navigate to random functions
4. See UI hang

Expected Behavior:
I expect the UI to not hang under analysis pressure

[jonpalmisc]

Note to myself: Took a look at this in Instruments. Looks like the repaint event (the likely culprit) this is primarily bounded Qt methods — doesn't mean things can't be optimized elsewhere, but there were no "easy win" performance gains when I went digging.

Possible solution: attempt to put a cap on the amount of repaints that occur in N .

[jonpalmisc]

@yrp604 The lag is disproportionately more noticeable when Stack View is open compared to anything else being open?

[plafosse]

It looks like under some conditions MLIL generation could be requested on the main thread and if the function being analyzed was large this could cause a hang until the MLIL had been generated. This should be fixed in: 5.1.7542