Skip to content

Conversation

@aurobindoc
Copy link
Contributor

@aurobindoc aurobindoc commented Aug 12, 2023

Added servers in SwaggerBundleConfiguration

Servers Dropdown added in Swagger UI

Servers Dropdown added in Swagger UI

Servers Dropdown Openned in Swagger U

Servers Dropdown Openned in Swagger UI

@ravidesai47
Copy link
Contributor

@aurobindoc I will review the same in next week

Meanwhile can you please confirm if the list of servers is not configured by the user then existing behaviour would be retained without breaking usage of the bundle or introducing regression?

@ravidesai47 ravidesai47 self-assigned this Aug 17, 2023
@ravidesai47 ravidesai47 removed the request for review from priyadharshini16 August 22, 2023 17:41
@ravidesai47
Copy link
Contributor

@aurobindoc Please share a sample screenshot over the MR description, how servers can be used on swagger UI for the reference. This would help anyone referring to this MR to understand how those servers can be accessed after adding the same in the config.

@aurobindoc
Copy link
Contributor Author

@aurobindoc I will review the same in next week

Meanwhile can you please confirm if the list of servers is not configured by the user then existing behaviour would be retained without breaking usage of the bundle or introducing regression?

Yes, I have verified that if the server config is not present in swagger config, still it works the similar way as it is.
But when it is added, we can see the server as a dropdown in the swagger UI

@ravidesai47 ravidesai47 merged commit d9836ac into Vect0rPro:master Aug 28, 2023
@ravidesai47
Copy link
Contributor

Release version 2.0.28-2 has been deployed to Maven Central with the changes merged as a part of this PR.

Link to GitHub Release: https://github.com/Vect0rPro/dropwizard-swagger/releases/tag/v2.0.28-2
Link to Maven Central Artifact: https://central.sonatype.com/artifact/in.vectorpro.dropwizard/dropwizard-swagger/2.0.28-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants