Updated vaibhav-1508#2

src/array.js

@@ -11,8 +11,7 @@
  *    [0, 1, 2, 3, 4, 5], 5    => 5
  */
 function findElement(arr, value) {
-
-		return arr.indexOf(value);
+  return arr.indexOf(value);
 }
 
 /**
@@ -28,12 +27,11 @@ function findElement(arr, value) {
  *    [] => []
  */
 function doubleArray(arr) {
-	let n =arr.length;
-	for(let i=0; i<n;i++)
-	{
-		arr.push(arr[i]);
-	}
-	return arr;
+  let n = arr.length;
+  for (let i = 0; i < n; i++) {
+    arr.push(arr[i]);
+  }
+  return arr;
 }
 
 /**
@@ -48,7 +46,7 @@ function doubleArray(arr) {
  *    [] => []
  */
 function getArrayOfPositives(arr) {
-	return arr.filter(elmt => elmt>0);
+  return arr.filter((elmt) => elmt > 0);
 }
 
 /**
@@ -64,12 +62,18 @@ function getArrayOfPositives(arr) {
  *    [ 1, 2, 3, 4, 5, 'false' ]         => [ 1, 2, 3, 4, 5, 'false' ]
  *    [ false, 0, NaN, '', undefined ]   => [ ]
  */
-function falsy(elmt)
-{
-	return ((elmt != false) && (elmt != '') && (elmt != null) && (elmt !=0) &&(elmt != undefined) && (("" +elmt)!= "NaN"));
+function falsy(elmt) {
+  return (
+    elmt != false &&
+    elmt != "" &&
+    elmt != null &&
+    elmt != 0 &&
+    elmt != undefined &&
+    "" + elmt != "NaN"
+  );
 }
 function removeFalsyValues(arr) {
-	return arr.filter(falsy);
+  return arr.filter(falsy);
 }
 
 /**
@@ -83,12 +87,8 @@ function removeFalsyValues(arr) {
  *    [ 'angular', 'react', 'ember' ] => [ 7, 5, 5 ]
  */
 function getStringsLength(arr) {
-	let arr2=[];
-	for(let i=0;i<arr.length;i++)
-	{
-		arr2.push(arr[i].length);
-	}
-	return arr2;
+  let mapping = arr.map((str) => str.length);
+  return mapping;
 }
 
 /**
@@ -104,16 +104,14 @@ function getStringsLength(arr) {
  *   [ 1, 10, 100, 1000 ]  => 1111
  */
 function getItemsSum(arr) {
-	let sum=0;
-	arr.forEach(elmt => sum += elmt);
-	return sum;
+  return arr.reduce((accSum, elmt) => accSum + elmt, 0);
 }
 
 module.exports = {
-	findElement,
-	doubleArray,
-	getArrayOfPositives,
-	removeFalsyValues,
-	getStringsLength,
-	getItemsSum,
+  findElement,
+  doubleArray,
+  getArrayOfPositives,
+  removeFalsyValues,
+  getStringsLength,
+  getItemsSum,
 };

src/conditionalAndLoops.js

@@ -88,12 +88,7 @@ function getSumBetweenNumbers(n1, n2) {
  *   10,10,10 =>  true
  */
 function isTriangle(a, b, c) {
-	if ((a + b > c && b + c > a && a + c > b)) {
-		return true;
-	}
-	else {
-		return false;
-	}
+	return (a + b > c && b + c > a && a + c > b);
 }
 
 /**
@@ -237,13 +232,28 @@ function timespanToHumanString(startDate, endDate) {
  *    365, 10 => '365'
  */
 let str = "";
+let converter = {
+	10: "a",
+	11: "b",
+	12: "c",
+	13: "d",
+	14: "e",
+	15: "f"
+}
 function generate(num, n) {
 	if (num < n) {
 		str += num;
 		return;
 	}
 	generate(Math.floor(num / n), n);
-	str += (num % n);
+	if(num%n < 10)
+	{
+		str += (num % n);
+	}
+	else
+	{
+		str += (converter[num%n]);
+	}
 }
 function toNaryString(num, n) {
 	str = "";

src/strangerThings.js

@@ -13,15 +13,15 @@ This function should return a list of all the distinct characters in UPPERCASE t
 function getCharacters() {
 	let msg = document.getElementById("message").value;
 	let str = [];
-	console.log(msg.length);
 	for(let i=0; i<msg.length; i++)
 	{
-		if(str.includes(msg[i]) == false && msg[i]!= " ")
+		if(!str.includes(msg[i]))
 		{
 			str.push(msg[i].toUpperCase());
 		}
 	}
-	return str;
+
+	return str.filter(elmt => elmt!=" ");
 }
 
 /* 
@@ -68,6 +68,9 @@ async function illuminateLight(index) {
 	{
 		await setCSS(message[i]);
 	}
+	// message.forEach(async function illumine(element) {
+	// 	await setCSS(element)
+	// });
 	/*
     TODO: Can the setCSS function asynchronously for each character present in the message array
     */

src/strings.js

@@ -11,8 +11,7 @@
  *   '',  'bb'  => 'bb'
  */
 function concatenateStrings(value1, value2) {
-	const ans = value1 + value2;
-	return ans;
+	return value1 + value2;
 }
 
 /**