feat(Makefile): GO variable, several improvements #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axtloss
reviewed
Sep 11, 2024
vigress8
force-pushed
the
makefile-improve
branch
from
e16ab72
to
bfbab91
Compare
axtloss
reviewed
Sep 11, 2024
vigress8
force-pushed
the
makefile-improve
branch
from
bfbab91
to
870ab9b
Compare
vigress8
changed the title
vigress8
force-pushed
the
makefile-improve
branch
from
870ab9b
to
9b2088d
Compare
axtloss
reviewed
Sep 12, 2024
* add GO variable to specify the path to the `go` binary * make `BINARY_NAME` a target, so `make install` only rebuilds if the binary is not present * assign variables using `:=` (simple expansion) to avoid potential gotchas caused by recursive expansion
vigress8
force-pushed
the
makefile-improve
branch
from
9b2088d
to
5f84abc
Compare
axtloss
approved these changes
Sep 12, 2024
|
githubs mobile is a bit confusing, did you squash all commits into one already? |
|
I did |
|
ok great, thanks for improving the makefile! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOvariable to specify the path to thegobinaryBINARY_NAMEa target, somake installonly rebuilds if the binary is not present:=(simple expansion) to avoid potential gotchas caused by recursive expansion