Added buffer security checks in sentence.cpp #334
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This and other known security issues have been resolved in the latest SDK update |
|
@Nephyrin, will those security fixes be backported to earlier engine versions (2006 SDK in particular)? |
|
@squeek502 seems extremely unlikely. |
GamerDude27
added a commit
to Nbc66/source-sdk-2013-ce
that referenced
this pull request
Sep 13, 2020
Necroposter here. This security vulnerability is also present in the SP branch, at relevant lines starting from https://github.com/ValveSoftware/source-sdk-2013/blob/master/sp/src/public/sentence.cpp#L457 onward based on the Files changed section here. Was this ever also applied to the SP branch, Nephyrin, or only the MP branch? |
FriskTheFallenHuman
added a commit
to FriskTheFallenHuman/mapbase-mp
that referenced
this pull request
Nov 28, 2022
strubium
added a commit
to strubium/source-sdk-2013-smeagled
that referenced
this pull request
Feb 27, 2024
Rainyan
pushed a commit
to NeotokyoRebuild/neo
that referenced
this pull request
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a buffer overflow using malicious sound files. This exploit is currently commonly being used during the current attacks on Source engine games and allows for arbitrary code execution.
Affected mods include but are not limited to:
IMPORTANT: This is by far not the only vulnerability available to these mods. Most vulnerabilities are contained in the Source SDK 2013 Base and are not available in code form. In live games such as TF2 and CS:GO, many of these have been patched. I recommend that these changes are ported immediately.
--PistonMiner