vpc: Remove Python dependency for embedding VScripts at compile-time #1664
+62
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copperpixel
force-pushed
the
devtools_native_scripts
branch
from
ed5241a to
fcada18
Compare
|
I get errors while building on Windows |
Contributor
Author
Can you show the build logs and does it still occur with the latest version? |
Contributor
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This Python script is used as a custom build step to embed VScripts into the C++ code to run in the VScript VM.
It's a simple task that this PR ports to native scripting solutions (PowerShell and Bourne shell on Windows and Linux respectively) so it doesn't require installing a whole language interpreter.