[TF2] Separate Voice and Chat mutes #1426
Open
+270
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Bradasparky <49656562+bradasparky@users.noreply.github.com>
henke37
reviewed
Jul 17, 2025
| @@ -317,7 +317,7 @@ void CDrawingPanel::FireGameEvent( IGameEvent *event ) | |||
| // If a player is muted for voice, also mute them for lines because jerks gonna jerk. | |||
There was a problem hiding this comment.
Is this comment still accurate? Looks like it probably is. But should it remain like this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the option to mute players into two separate options, voice and chat. The mute menu and scoreboard context menu have been updated to display these options.
In order to achieve two separate mute options, the method of writing to
voice_ban.dtwas updated to include saving per player ban flags. All functions responsible for parsing mute statuses between players have been modified to use a ban flag parameter instead of a boolean.Additionally, the
MutePlayerDialog.reswas updated to use new translation strings withinmod_tf_english.txtShowcase
Mute Dialog
Scoreboard context menu mute
Potential Volume Warning
Voice-Chat-Pr.1.mp4