Add nullptr check for pTFAttacker #1379
Open
+15
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a very rare crash in
source-sdk-2013/src/game/shared/tf/tf_gamerules.cpp
Lines 10659 to 10661 in 39f6dde
As you can see
pOwner
is never null checked for. And in very rare instancessource-sdk-2013/src/game/server/tf/tf_player.cpp
Lines 9840 to 9855 in 39f6dde
That function is called when
pTFAttacker
is nullptr.Since
pTFAttacker
is already null-checked in lot of places insideint CTFPlayer::OnTakeDamage( const CTakeDamageInfo &inputInfo )
let's just add one extra check there (see PR changes).