[HL2MP] Fix bots rapidly switching to and from gravity gun #1372
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a HL2MP bot approaches a prop to pick up, it sometimes rapidly switches between its gravity gun and a different weapon. This is because
CHL2MPBot::EquipRequiredWeapon()
returnsWeapon_Switch
directly when using the weapon stack, which is false when the weapon is already out. This causes the required weapon to only be enforced when it is not equipped, hence why it switches back so quickly when another weapon takes its place. This pull request callsWeapon_Switch
without using its value and always returns true like with the weapon restriction cases.The prop behavior is the only component that uses the weapon stack, but any other behavior using it would presumably experience a similar issue.