tf2: Fix MvM bots not being able to use their items #1365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will affect balance of Mann Up/Boot Camp heavily, I'd recommend making it convar that is turn-onable for community servers instead |
|
This is fixing broken behavior introduced in Gun Mettle, due to the increased switch speed. I do not see how this affects the balance. |
zxz41
reviewed
Jun 22, 2025
| @@ -47,9 +47,12 @@ ActionResult< CTFBot > CTFBotUseItem::Update( CTFBot *me, float interval ) | |||
| { | |||
| if ( m_cooldownTimer.IsElapsed() ) | |||
There was a problem hiding this comment.
I know this is a bit of format nitpicking, but the if statements can be combined into one like so.
Suggested change
| if ( m_cooldownTimer.IsElapsed() ) | |
| if ( m_cooldownTimer.IsElapsed() && me->GetNextAttack() <= gpGlobals->curtime ) |
What? This is a bug messing with the gameplay. How is that related to balance in any way? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, robots in MvM mode can not use their items (Buff Banner, Bonk, etc.), due to the timer in
CTFBotUseItemending before the weapon is fully deployed. This leads to a loop of robots constantly switching to their items without activating it.We should wait until the bot is actually able to "attack" aka use the item.
Resubmission of #875 due to a deleted fork