drm: support tiled displays as a single logical output - #2344
Open
arnoutzw wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add DRM
TILEsupport to the embedded backend so a tiled monitor is driven as one logical output instead of selecting only one connector.This change:
TILEblobs and normalizes selection to tile(0,0)Problem
The 5K panel in the iMac18,3 is exposed by DRM as a 2x1 tile group:
eDP-1: tile(0,0), 2560x2880DP-1: tile(1,0), 2560x2880Gamescope previously selected only one connector. In an embedded Steam/Game Mode session this left the physical 5120x2880 display black or only partially driven, even though desktop compositors with tiled-output support could use the panel.
Testing
Hardware-tested on an Apple iMac18,3 with an AMD Radeon Pro 580X (Polaris10), amdgpu, and a 5120x2880@60 panel exposed as the two connectors above.
Observed with the patched embedded session:
The Steam Game Mode UI was visible and usable across the complete panel. DRM diagnostics also showed both tile planes scanning out cropped halves of the same 5120x2880 framebuffer.
The hardware run used the 3.16.25-based version of this patch. This branch has subsequently been rebased onto current
master, adapted to the currentFrameInfo_t::LayerStack_tAPI, and compile-checked with: