feat: Initialize Portfolio with Existing Positions and Enhance Data Fetching Reliability #463
+110
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etching Reliability This pull request introduces two major enhancements to the portfolio initialization process: 1. Initial Position Loading: The system now correctly loads and integrates any existing open positions into the PortfolioView at startup. 2. Robust Data Fetching: A retry mechanism has been implemented for fetching portfolio data to improve reliability against transient network or API errors.
Collaborator
|
Thank you for your contribution! Could you please elaborate a bit on why the Initial Position Loading feature is needed? We are concerned that introducing this feature might impact the accuracy of return rate calculations and the integrity of shared data. We would love to understand your use case better to ensure these metrics remain accurate. Looking forward to your reply. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Pull Request Template
1. Related Issue
Closes # (issue number)
2. Type of Change (select one)
Type of Change: New Feature
3. Description
This pull request introduces two major enhancements to the portfolio initialization process:
4. Testing
5. Checklist