Skip to content

Conversation

@CyrilCh
Copy link

@CyrilCh CyrilCh commented Nov 20, 2025

  • Add docker-compose.yml for orchestrating frontend and backend services

  • Add Dockerfile.backend for building backend container

  • Add Dockerfile.frontend for building frontend container

  • Add .dockerignore to exclude unnecessary files

  • Add docker documentation and scripts

  • Add database migration script

📝 Pull Request Template

1. Related Issue

Closes # (issue number)

Type of Change (select one)

Type of Change: Other: docker env_

3. Description

环境一致性:容器化确保开发、测试、生产环境一致
简化部署:docker-compose up 一键启动
开发体验:热重载支持,代码修改即时生效
性能优化:使用国内镜像源加速构建

4. Testing

  • I have tested this locally.
  • I have updated or added relevant tests.

5. Checklist

- Add docker-compose.yml for orchestrating frontend and backend services

- Add Dockerfile.backend for building backend container

- Add Dockerfile.frontend for building frontend container

- Add .dockerignore to exclude unnecessary files

- Add docker documentation and scripts

- Add database migration script
…uction_id, avg_exec_price, realized_pnl, etc.)
Copy link
Contributor

@hazeone hazeone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your Pull Request! Please update the content to the English version and remove the processing file.

Note: We will support the ValueCell App on both MAC and Windows platforms. All configurations will be managed via a GUI and stored in local files. So maybe you should give a test for the docker environment. Reference: https://github.com/ValueCell-ai/valuecell/blob/main/python/valuecell/__init__.py

… files

- Changed the database volume mapping in `docker-compose.yml` to use a dedicated `data` directory.
- Added a new environment variable `VALUECELL_SQLITE_DB` for SQLite database configuration.
- Updated `Dockerfile.backend` to include an entrypoint script for database initialization.
- Removed obsolete `daemon.json.example` and related documentation files.
- Enhanced database path resolution in `db.py` to support both URL and filesystem path formats.
@CyrilCh
Copy link
Author

CyrilCh commented Nov 26, 2025

Thank you for your review and valuable feedback! I have completed the following updates as requested:

  1. Updated all relevant content to the English version;
  2. Removed the processing file as specified;please let me know if my understanding of the "processing file" to be removed is incorrect – I’m happy to make further adjustments promptly;
  3. Completed Docker build and functional testing on the Windows environment based on the latest commit.
    I have pushed all these updates to this Pull Request. Please feel free to review them, and let me know if any further adjustments or additional tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants