-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: add Docker container build configuration #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add docker-compose.yml for orchestrating frontend and backend services - Add Dockerfile.backend for building backend container - Add Dockerfile.frontend for building frontend container - Add .dockerignore to exclude unnecessary files - Add docker documentation and scripts - Add database migration script
…uction_id, avg_exec_price, realized_pnl, etc.)
hazeone
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your Pull Request! Please update the content to the English version and remove the processing file.
Note: We will support the ValueCell App on both MAC and Windows platforms. All configurations will be managed via a GUI and stored in local files. So maybe you should give a test for the docker environment. Reference: https://github.com/ValueCell-ai/valuecell/blob/main/python/valuecell/__init__.py
… files - Changed the database volume mapping in `docker-compose.yml` to use a dedicated `data` directory. - Added a new environment variable `VALUECELL_SQLITE_DB` for SQLite database configuration. - Updated `Dockerfile.backend` to include an entrypoint script for database initialization. - Removed obsolete `daemon.json.example` and related documentation files. - Enhanced database path resolution in `db.py` to support both URL and filesystem path formats.
|
Thank you for your review and valuable feedback! I have completed the following updates as requested:
|
Add docker-compose.yml for orchestrating frontend and backend services
Add Dockerfile.backend for building backend container
Add Dockerfile.frontend for building frontend container
Add .dockerignore to exclude unnecessary files
Add docker documentation and scripts
Add database migration script
📝 Pull Request Template
1. Related Issue
Closes # (issue number)
Type of Change (select one)
Type of Change: Other: docker env_
3. Description
环境一致性:容器化确保开发、测试、生产环境一致
简化部署:docker-compose up 一键启动
开发体验:热重载支持,代码修改即时生效
性能优化:使用国内镜像源加速构建
4. Testing
5. Checklist