Fixed erroneous computation of velocity during Grid computation for cosmo converter#25
Open
mstewart-vsc wants to merge 1 commit intoValkyrieSystems:mainfrom
Open
Conversation
mstewart-vsc
requested review from
bombaci-vsc,
johnstob,
mtrachy and
pressler-vsc
Contributor
|
Good catch. |
johnstob
approved these changes
Feb 18, 2026
pressler-vsc
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
cosmoconverter Grid unit vector computation to use the velocity at closest approach.This is consistent with the approach used for
terrasar,sentinel, andiceye.This change has no impact to geolocation.