Skip to content

Commit

Permalink
Document APIs relating to built-in and custom extensions
Browse files Browse the repository at this point in the history
While I'm here, unexport STACK_OF(X509V3_EXT_METHOD). We use it
internally, but it never appears in any public APIs, and there's no real
reason for any caller to use it.

Bug: 426
Change-Id: I6057834847a37f435d1b687701a3e65b5afb2890
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/66387
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
  • Loading branch information
davidben authored and Boringssl LUCI CQ committed Feb 23, 2024
1 parent a6e2be4 commit 9d7535f
Show file tree
Hide file tree
Showing 3 changed files with 283 additions and 207 deletions.
2 changes: 2 additions & 0 deletions crypto/x509/v3_lib.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,8 @@

#include "ext_dat.h"

DEFINE_STACK_OF(X509V3_EXT_METHOD)

static STACK_OF(X509V3_EXT_METHOD) *ext_list = NULL;

static int ext_stack_cmp(const X509V3_EXT_METHOD *const *a,
Expand Down
4 changes: 2 additions & 2 deletions include/openssl/obj.h
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ OPENSSL_EXPORT int OBJ_obj2txt(char *out, int out_len, const ASN1_OBJECT *obj,
// duplicate OIDs, short names, or long names. If two callers in the same
// address space add conflicting values, only one registration will take effect.
// Avoid this function if possible. Instead, callers can process OIDs unknown to
// BoringSSL by acting on the byte representation directly. See |OBJ_get0_data|
// and |OBJ_length|.
// BoringSSL by acting on the byte representation directly. See
// |ASN1_OBJECT_create|, |OBJ_get0_data|, and |OBJ_length|.
OPENSSL_EXPORT int OBJ_create(const char *oid, const char *short_name,
const char *long_name);

Expand Down
Loading

0 comments on commit 9d7535f

Please sign in to comment.