Skip to content

Commit

Permalink
Bump the minimum MSVC version to 2022
Browse files Browse the repository at this point in the history
Per
https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md,
we can require VS2022 or later.

Looking at notable downstreams, Envoy doesn't support Windows at all
anymore, and gRPC raised their minimum in
grpc/grpc#37687

Update-Note: On Windows, MSVC 2022 or later is now allowed. This change
will make the vs2022 configs on CI redundant with the default ones. I'll
remove the redundant ones after this lands.

Change-Id: Ib740e091271c94e0ef8999e61a31a8e3df63f349
Reviewed-on: https://boringssl-review.googlesource.com/c/boringssl/+/71830
Auto-Submit: David Benjamin <davidben@google.com>
Commit-Queue: David Benjamin <davidben@google.com>
Commit-Queue: Bob Beck <bbe@google.com>
Reviewed-by: Bob Beck <bbe@google.com>
  • Loading branch information
davidben authored and Boringssl LUCI CQ committed Oct 8, 2024
1 parent fa02146 commit 2570b28
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 11 deletions.
2 changes: 1 addition & 1 deletion BUILDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ most recent stable version of each tool.
`CMAKE_ASM_NASM_COMPILER`.

* Compilers for C11 and C++14, or later, are required. On Windows, MSVC from
Visual Studio 2019 or later with Windows 10 SDK 2104 or later are
Visual Studio 2022 or later with Windows 10 SDK 2104 or later are
supported, but using the latest versions is recommended. Recent versions of
GCC (6.1+) and Clang should work on non-Windows platforms, and maybe on
Windows too.
Expand Down
2 changes: 1 addition & 1 deletion util/bot/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ vars = {
'checkout_nasm': False,
'checkout_libcxx': False,
'checkout_riscv64': False,
'vs_version': '2019',
'vs_version': '2022',

# Run the following command to see the latest builds in CIPD:
# cipd describe PACKAGE_NAME -version latest
Expand Down
9 changes: 0 additions & 9 deletions util/bot/vs_toolchain.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,15 +63,6 @@ def FindDepotTools():
def _GetDesiredVsToolchainHashes(version):
"""Load a list of SHA1s corresponding to the toolchains that we want installed
to build with."""
if version == '2017':
# VS 2017 Update 9 (15.9.12) with 10.0.18362 SDK, 10.0.17763 version of
# Debuggers, and 10.0.17134 version of d3dcompiler_47.dll, with ARM64
# libraries.
return ['418b3076791776573a815eb298c8aa590307af63']
if version == '2019':
# VS 2019 16.61 with 10.0.20348.0 SDK, 10.0.22621.755 version of Debuggers,
# with ARM64 libraries and UWP support.
return ['0b5ee4d2b1']
if version == '2022':
# VS 2022 17.9.2 with 10.0.22621.2428 SDK with ARM64 libraries and UWP
# support.
Expand Down

0 comments on commit 2570b28

Please sign in to comment.