refactor: Add RunTestPaymentService and self-pay checks#4
Open
ValeraFinebits wants to merge 1 commit intomasterfrom
Open
refactor: Add RunTestPaymentService and self-pay checks#4ValeraFinebits wants to merge 1 commit intomasterfrom
ValeraFinebits wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stabilizes the RunTestPayment([FromBody] RunTestPaymentRequest, CancellationToken) self-pay diagnostic flow and makes failures easier to understand.
RunTestPayment([FromBody] RunTestPaymentRequest, CancellationToken) is a cheat-mode-only scenario where sender and receiver can operate against the same store wallet. That makes it useful for finding same-wallet payjoin edge cases, but it also exposed a flaky dust-output failure caused by sender/receiver change handling colliding in this self-pay path.
Changes
added explicit self-pay invariant validation for:
Why
This keeps RunTestPayment([FromBody] RunTestPaymentRequest, CancellationToken) useful as a deliberately weird same-wallet diagnostic scenario, while making it less flaky and much more actionable when it fails.